improvement: Added variable for not hardcoding root device name in aws node group

[alexandrst88]

PR o'clock

Description

Due to hardcoded device_name https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/modules/node_groups/launch_template.tf#L41. it's not possible to extend root block device.

Checklist

• [*] README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

[daroga0002]

I dont see issue linked to this PR, could you paste a config which is failing and which is solved by this PR?

[alexandrst88]

I dont see issue linked to this PR, could you paste a config which is failing and which is solved by this PR?

#1686

[stevehipwell]

@alexandrst88 you shouldn't be making changes to locals.tf for a default value in the node groups module. Please take a look at how defaults are set for node group only variables.

[tsurankov]

@alexandrst88 Any updates on this? I am going to use a custom Ubuntu AMI and have faced the same issue

[antonbabenko]

This issue has been resolved in version 18.0.0 🎉

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.