Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't tag self managed node security group with kubernetes.io/cluster tag #1774

Merged
merged 8 commits into from
Feb 2, 2022
Merged

fix: Don't tag self managed node security group with kubernetes.io/cluster tag #1774

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ddfd41c
fix: Don't tag self managed node security group with kubernetes.io/cl…
Jan 12, 2022
9b854dc
Merge branch 'master' into master
Jan 13, 2022
942975f
Merge branch 'master' into master
Jan 18, 2022
4989f2a
Merge branch 'master' into master
Jan 27, 2022
e9941e4
Merge branch 'master' of github.com:terraform-aws-modules/terraform-a…
Feb 2, 2022
b199eed
Merge branch 'master' into master
Feb 2, 2022
b20913a
fix: Add back "Name" tag in self managed node groups
Feb 2, 2022
50ac6f4
Merge branch 'master' of github.com:imdevin567/terraform-aws-eks
Feb 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions modules/self-managed-node-group/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,8 +460,7 @@ resource "aws_security_group" "this" {
tags = merge(
var.tags,
{
"Name" = local.security_group_name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add back in the "Name" tag, then we should be good to go with this one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be all set now.

"kubernetes.io/cluster/${var.cluster_name}" = "owned"
"Name" = local.security_group_name
},
var.security_group_tags
)
Expand Down