feat: Add prometheus-adapter port 6443 to recommended sec groups #2399
Conversation
I wonder if [kubernetes-sigs/prometheus-adapter](https://github.com/kubernetes-sigs/prometheus-adapter) can be added to the default recommended security groups. When deployed with kube-prometheus/kube-prometheus-stack/helm/manifests it uses port 6443. Thinking if metrics-server could be added by default so can prometheus-adapter
## [19.6.0](v19.5.1...v19.6.0) (2023-01-28) ### Features * Add prometheus-adapter port 6443 to recommended sec groups ([#2399](#2399)) ([059dc0c](059dc0c))
|
This PR is included in version 19.6.0 🎉 |
|
I used to add precisely the same rule for KEDA, another metrics server(among other things). not sure if it's worth mentioning in the comments(and docs?) that it's not only |
terraform-aws-modules/terraform-aws-eks#2399 eliminated the need of adding additional rule to security groups. Signed-off-by: Timur Bakeyev <timur@bat.consulting>
terraform-aws-modules/terraform-aws-eks#2399 eliminated the need of adding additional rule to security groups. Signed-off-by: Timur Bakeyev <timur@bat.consulting>
|
yes, that would be great to add a note on if you want to submit a PR |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
I wonder if kubernetes-sigs/prometheus-adapter can be added to the default recommended security groups.
When deployed with kube-prometheus/kube-prometheus-stack/helm/manifests it uses port 6443.
Thinking if metrics-server could be added by default so can prometheus-adapter.
Motivation and Context
To have the Kubernetes aggregated API v1beta1.metrics.k8s.io/default available by default if using the prom-adapter.
Breaking Changes
None
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projects