Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for AL2023 nodeadm user data #2942

Merged
merged 5 commits into from
Mar 1, 2024

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Feb 22, 2024

Description

  • Add support for AL2023 nodeadm user data

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

ToDo

  • Remove pre and post bootstrap fields from AL2023 templates - this isn't valid/warranted with MIME multi-part
  • Add example nodegroup for both EKS and self-managed nodegroup
  • Validate GA API

@bryantbiggs bryantbiggs marked this pull request as ready for review February 29, 2024 22:02
@bryantbiggs
Copy link
Member Author

this is now GA so flipping the switch to ready https://aws.amazon.com/about-aws/whats-new/2024/02/amazon-eks-support-linux-2023/

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Small question only.

modules/_user_data/main.tf Outdated Show resolved Hide resolved
@bryantbiggs bryantbiggs merged commit 7c99bb1 into terraform-aws-modules:master Mar 1, 2024
17 checks passed
@bryantbiggs bryantbiggs deleted the feat/al2023 branch March 1, 2024 00:12
antonbabenko pushed a commit that referenced this pull request Mar 1, 2024
## [20.5.0](v20.4.0...v20.5.0) (2024-03-01)

### Features

* Add support for AL2023 `nodeadm` user data ([#2942](#2942)) ([7c99bb1](7c99bb1))
@antonbabenko
Copy link
Member

This PR is included in version 20.5.0 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support AL2023
2 participants