Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add supprot for creating placement group for managed node group #2959

Merged

Conversation

james-masson
Copy link
Contributor

Description

Adds the ability to have a placement group created for your managed node group, with configurable strategy.

Motivation and Context

The EFA feature added placement groups in a very specific way, this makes placement groups available for use outside of EFA.

Breaking Changes

None

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs
Copy link
Member

the clustered placement group for EFA is a requirement - what is the reason for needing other placement group (i.e. - spread) functionality?

@james-masson
Copy link
Contributor Author

We run low-latency workloads, and need placement groups to co-locate all the members of the nodegroup.

@bryantbiggs Your EFA PR allowed management of placement groups directly from the module, rather than just being a pre-supplied thing. However the rest of your change heavily tied placement groups to EFA only - when it could be a more generic feature.

This PR allows anyone to use placement groups with any policy they like, without enabling the rest of your EFA support.

The functionality of your EFA change is intact.

@bryantbiggs bryantbiggs changed the title feat: Placement groups with managed node groups feat: Add supprot for creating placement group for managed node group Mar 9, 2024
@bryantbiggs bryantbiggs merged commit 3031631 into terraform-aws-modules:master Mar 9, 2024
18 checks passed
antonbabenko pushed a commit that referenced this pull request Mar 9, 2024
## [20.7.0](v20.6.0...v20.7.0) (2024-03-09)

### Features

* Add supprot for creating placement group for managed node group ([#2959](#2959)) ([3031631](3031631))
@antonbabenko
Copy link
Member

This PR is included in version 20.7.0 🎉

@james-masson james-masson deleted the feat/placement-groups branch March 11, 2024 09:10
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants