fix: Add explicit to_map for empty object for aws_cloudwatch_event_target

[katariax]

For resource aws_cloudwatch_event_target, add explicit conversion using to_map for the empty object in ternary operator, to avoid the error "Error: Inconsistent conditional result types""

Description

In file main.tf, for resource aws_cloudwatch_event_target, the for_each command has a ternary operator with default value for not-match as empty object : {}

In some cases, terraform is throwing error Inconsistent conditional result types ...... The true and false result expressions must have consistent types. The given expressions are object and object, respectively.

By explicitly type converting empty object to map, the error is resolved.

% terraform plan
╷
│ Error: Inconsistent conditional result types
│
│   on ../../main.tf line 49, in resource "aws_cloudwatch_event_target" "this":
│   49:   for_each = var.create && var.create_targets ? {
│   50:     for target in local.eventbridge_targets : target.name => target
│   51:   } : {}
│     ├────────────────
│     │ local.eventbridge_targets is tuple with 8 elements
│     │ var.create is true
│     │ var.create_targets is true
│
│ The true and false result expressions must have consistent types. The given expressions are object and object, respectively.

Motivation and Context

Fix for Issue #23

Breaking Changes

Does this break backwards compatibility with the current major version? No

How Has This Been Tested?

• [x ] I have tested and validated these changes using one or more of the provided examples/* projects

For all the examples , ran terraform init and terraform plan. Both init and plan were successful for all the examples .
Attached terraform init and plan output : terraform-test-output-20210819.txt

[shufo]

Had the same exception with terraform v1.0.5 in my environment and fixed with this change.
I would appreciate if this will be merged.

[antonbabenko]

Thanks, @katariax !

v1.9.0 has been just released.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.