Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Replace use of toset() for policy attachment, bump min version of AWS provider to 4.0 and Terraform to 1.0 #250

Merged
merged 3 commits into from
May 18, 2022
Merged

feat!: Replace use of toset() for policy attachment, bump min version of AWS provider to 4.0 and Terraform to 1.0 #250

merged 3 commits into from
May 18, 2022

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented May 15, 2022 •
edited
Loading

Description

Motivation and Context

Breaking Changes

  • Yes, fixing a well known issue and keeping provider current to utilize latest features and fixes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

bryantbiggs
bryantbiggs commented May 15, 2022
View reviewed changes
examples/iam-role-for-service-accounts-eks/main.tf
]
role_policy_arns = {
AmazonEKS_CNI_Policy = "arn:aws:iam::aws:policy/AmazonEKS_CNI_Policy"
additional = aws_iam_policy.additional.arn
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demonstrates computed resource usage which is what was raised in #193

@bryantbiggs bryantbiggs mentioned this pull request May 15, 2022
Closed
@bryantbiggs
Copy link
Member Author

@antonbabenko would it be worthwhile to go up to 0.14 to use sensitive on inputs?

@bryantbiggs
Copy link
Member Author

@antonbabenko just FYI in case you missed it - happy to hear your thoughts 😬

@antonbabenko
Copy link
Member

I was away for a few days, got 100000001 unread notifications from GitHub :)

The PR looks very good. I agree, let's upgrade to 0.14 just for sensitive.

Keep in mind, that 0.15 had the same amount of improvements for sensitive as during 0.14 releases.

@bryantbiggs
Copy link
Member Author

No worries, I figured! Let me take at 0.15 vs 0.14 differences, most likely safe to go to 0.15

max-rocket-internet
max-rocket-internet approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@max-rocket-internet max-rocket-internet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💖

@bryantbiggs bryantbiggs changed the title feat!: Replace use of toset() for policy attachment, bump min version of AWS provider to 4.0 and Terraform to 0.13.1 feat!: Replace use of toset() for policy attachment, bump min version of AWS provider to 4.0 and Terraform to 1.0 May 18, 2022
@bryantbiggs
Copy link
Member Author

@antonbabenko went all the way up to 1.0

@antonbabenko
Copy link
Member

@bryantbiggs terraform-aws-modules going GA! Hooray! 🎉

Looks good to me

@antonbabenko
Copy link
Member

@bryantbiggs Please merge whenever you are ready.

@bryantbiggs
Copy link
Member Author

@antonbabenko it looks like you need to approve first before I can merge 😅

@bryantbiggs bryantbiggs merged commit 835135b into terraform-aws-modules:master May 18, 2022
@bryantbiggs bryantbiggs deleted the refactor/breaking-change branch May 18, 2022 19:05
antonbabenko pushed a commit that referenced this pull request May 18, 2022
@semantic-release-bot
chore(release): version 5.0.0 [skip ci]
be6303e 
## [5.0.0](v4.24.1...v5.0.0) (2022-05-18)

### ⚠ BREAKING CHANGES

* Replace use of `toset()` for policy attachment, bump min version of AWS provider to `4.0` and Terraform to `1.0` (#250)

### Features

* Replace use of `toset()` for policy attachment, bump min version of AWS provider to `4.0` and Terraform to `1.0` ([#250](#250)) ([835135b](835135b))
@antonbabenko
Copy link
Member

This PR is included in version 5.0.0 🎉

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@max-rocket-internet max-rocket-internet max-rocket-internet approved these changes

@antonbabenko antonbabenko antonbabenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iam-eks-role cannot attach a policy created in the same module using role_policy_arns input
3 participants
@bryantbiggs @antonbabenko @max-rocket-internet