Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Do not call data resources when create is false #25

Merged
merged 1 commit into from
Nov 3, 2023
Merged

feat: Do not call data resources when create is false #25

merged 1 commit into from
Nov 3, 2023

Conversation

bryantbiggs
Copy link
Member

Description

  • Do not call data resources when create is false

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs mentioned this pull request Nov 3, 2023
Closed
antonbabenko
antonbabenko approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@bryantbiggs bryantbiggs merged commit 4951c38 into terraform-aws-modules:master Nov 3, 2023
7 checks passed
@bryantbiggs bryantbiggs deleted the feat/disable-data branch November 3, 2023 22:39
antonbabenko pushed a commit that referenced this pull request Nov 3, 2023
@semantic-release-bot
chore(release): version 2.1.0 [skip ci]
5508c9c 
## [2.1.0](v2.0.1...v2.1.0) (2023-11-03)

### Features

* Do not call data resources when `create` is `false` ([#25](#25)) ([4951c38](4951c38))
@antonbabenko
Copy link
Member

This PR is included in version 2.1.0 🎉

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko antonbabenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bryantbiggs @antonbabenko