Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add explicit default value for engine_mode used in conditiona logic internally #347

Merged
merged 3 commits into from
Feb 7, 2023

Conversation

pdeva
Copy link
Contributor

@pdeva pdeva commented Jan 3, 2023

sets default value for engine_mode var as is in the description

Description

sets default value for engine_mode.

Motivation and Context

without this, if engine_mode is not specified, serverlessv2_scaling_configuration will not take effect since it expects an actual value of provisioned in engine_mode

Breaking Changes

None

How Has This Been Tested?

  • [ x] I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • [x ] I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

sets default value for `engine_mode` var as is in the description
@bryantbiggs
Copy link
Member

Can you provide more details and a reproduction as to the issue you are facing? This is the default value that is specified by the provider https://github.com/hashicorp/terraform-provider-aws/blob/d9290535ae088a600ddec41fe63e899185d74b56/internal/service/rds/cluster.go#L181

@pdeva
Copy link
Contributor Author

pdeva commented Jan 3, 2023

this line

for_each = length(var.serverlessv2_scaling_configuration) > 0 && var.engine_mode == "provisioned" ? [var.serverlessv2_scaling_configuration] : []
is not triggered if an explicit value is not specified for engine_mode

@bryantbiggs bryantbiggs changed the title default value for engine_mode fix: Add explicit default value for engine_mode used in conditiona logic internally Jan 3, 2023
@bryantbiggs
Copy link
Member

thank you - that makes a lot more sense now and I agree, this value is necessary to support that logic

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Feb 3, 2023
@bryantbiggs bryantbiggs merged commit 7ffa33f into terraform-aws-modules:master Feb 7, 2023
antonbabenko pushed a commit that referenced this pull request Feb 7, 2023
### [7.6.2](v7.6.1...v7.6.2) (2023-02-07)

### Bug Fixes

* Add explicit default value for `engine_mode` used in conditiona logic internally ([#347](#347)) ([7ffa33f](7ffa33f))
@antonbabenko
Copy link
Member

This PR is included in version 7.6.2 🎉

@pdeva pdeva deleted the patch-1 branch February 7, 2023 18:13
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants