-
-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add explicit default value for engine_mode
used in conditiona logic internally
#347
Conversation
sets default value for `engine_mode` var as is in the description
Can you provide more details and a reproduction as to the issue you are facing? This is the default value that is specified by the provider https://github.com/hashicorp/terraform-provider-aws/blob/d9290535ae088a600ddec41fe63e899185d74b56/internal/service/rds/cluster.go#L181 |
this line terraform-aws-rds-aurora/main.tf Line 136 in 973666e
|
engine_mode
used in conditiona logic internally
thank you - that makes a lot more sense now and I agree, this value is necessary to support that logic |
This PR has been automatically marked as stale because it has been open 30 days |
### [7.6.2](v7.6.1...v7.6.2) (2023-02-07) ### Bug Fixes * Add explicit default value for `engine_mode` used in conditiona logic internally ([#347](#347)) ([7ffa33f](7ffa33f))
This PR is included in version 7.6.2 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
sets default value for
engine_mode
var as is in the descriptionDescription
sets default value for
engine_mode
.Motivation and Context
without this, if engine_mode is not specified,
serverlessv2_scaling_configuration
will not take effect since it expects an actual value ofprovisioned
inengine_mode
Breaking Changes
None
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request