fix: mark "this_rds_cluster_master_username" output as sensitive

[kayvonr]

Description

Marking the username output field as sensitive, as this now seems to be required by the AWS provider

Motivation and Context

Our terraform cloud workspaces now, either with an upgrade to terraform >=0.14.3 or an upgrade of the aws provider version, now result in a plan error stating that the username field should be marked as sensitive:

Error: Output refers to sensitive values

  on .terraform/modules/XXX/outputs.tf line 49:
  49: output "this_rds_cluster_master_username" {

Expressions used in outputs can only refer to sensitive values if the
sensitive attribute is true.

after applying this change on our fork to mark the username output as sensitive and using our forked repo as the provider (with no other diff to this main repo), the error no longer occurred and our plan + apply went through OK

Breaking Changes

None that we can see or determine. There is an update change in the plan output now that is just informing you of the newly marked sensitivity of the field.

How Has This Been Tested?

We have run our terraform plans + applies against our fork with the field marked as sensitive. We have not seen any planned changes to the resources (other than the info about the new field status mentioned above), no modifications to our aurora instances, no newly pending maintenance as a result of applying this change.

[bryantbiggs]

@antonbabenko 👍🏼

[antonbabenko]

master_username is not sensitive but master_password is according to the AWS provider code:

https://github.com/hashicorp/terraform-provider-aws/blob/b4205b93ee3ae4c1398e1a5076f8e87fcb1b93ef/aws/resource_aws_rds_cluster.go#L333-L344

@kayvonr I recommend you update your fork and mark username as not sensitive.

@bryantbiggs Do I miss something?

[bryantbiggs]

after checking all examples (see #200) I am not seeing this error show up. closing this out for now, but if you can provide more details on versions/configuration used/etc. we can look at trying to reproduce or provide insight

[okobylianskyi]

Getting the same issue after upgrading Terraform v0.14 -> v0.15.

Terraform v0.15.0
registry.terraform.io/hashicorp/aws v3.37.0
terraform-aws-modules/rds-aurora/aws v2.29.0 (upgraded to v 4.1.0, but still the error)

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.