Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Specify the number of read replicas as one less that total (#190) #193

Closed
wants to merge 7 commits into from
+2 −1
Closed

fix: Specify the number of read replicas as one less that total (#190) #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c74771d
fix: Specify the number of read replicas as one less that total insta…
Feb 17, 2021
0b82846
Merge branch 'master' into replica_count
emillbrandt Feb 22, 2021
44db498
Merge branch 'master' into replica_count
emillbrandt Mar 2, 2021
953a6a4
Merge branch 'master' into replica_count
emillbrandt Mar 8, 2021
310de6e
Merge branch 'master' into replica_count
emillbrandt Apr 6, 2021
e19db91
Merge branch 'master' into replica_count
emillbrandt Apr 15, 2021
cae691a
Lint
emillbrandt Apr 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ All notable changes to this project will be documented in this file.
<a name="unreleased"></a>
## [Unreleased]

- fix: Specify the number of read replicas as one less that total instances ([#190](https://github.com/terraform-aws-modules/terraform-aws-rds-aurora/issues/190))


<a name="v4.1.0"></a>
Expand Down
2 changes: 1 addition & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ resource "aws_rds_cluster" "this" {
}

resource "aws_rds_cluster_instance" "this" {
count = var.create_cluster ? (var.replica_scale_enabled ? var.replica_scale_min : var.replica_count) : 0
count = var.create_cluster ? (var.replica_scale_enabled ? var.replica_scale_min + 1 : var.replica_count + 1) : 0

identifier = try(lookup(var.instances_parameters[count.index], "instance_name"), "${var.name}-${count.index + 1}")
cluster_identifier = element(concat(aws_rds_cluster.this.*.id, [""]), 0)
Expand Down