-
-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update CI workflow to use composite actions, update pre-commit versions #242
chore: update CI workflow to use composite actions, update pre-commit versions #242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, but I am not sure if we need to do any changes related to GH secret token to be able to fix and commit changes made by pre-commit hooks into the PR?
Or is it for another PR?
No changes for GitHub token at this time - the functionality to update PRs is not included at this time until I can find out how best to manage the token |
Merged. Let's keep experiments limited to this repo, for now, to avoid mixing terraform-docs versions in various places. This one uses 0.16 but all others are using 0.13. When do you think you will be able to finish the work related to fixing&committing back to the repo? Let me know if you think I can help somehow. |
I don't know if its possible yet, I have to do some more research and testing. for users working directly off the repo it works as expected, but using forked copies it does not because the token is in the source repo and not in the forked repo. there are ways to share the token but I don't know the full implications of this yet (we obviously don't want to share tokens externally that have write access, etc.) |
Got it, I don't know who to ask about this other than GitHub forums and Google :) |
* terraform-aws-modules-master: (32 commits) chore: Giving up on releaserc config (for now) (terraform-aws-modules#257) chore(release): version 6.1.3 [skip ci] fix: Revert small useless change in main.tf (terraform-aws-modules#256) chore(release): version 6.1.2 [skip ci] fix: Small useless change in main.tf to test semantic-release (last one, I promise) (terraform-aws-modules#255) fix: Small useless change in main.tf to test semantic-release (terraform-aws-modules#254) chore: Updated .releaserc config and tf file (to trigger release) (terraform-aws-modules#253) chore: Updated .releaserc config (terraform-aws-modules#252) chore(release): version 6.1.1 [skip ci] chore: Added workflow_dispatch to allow manual releases (terraform-aws-modules#251) fix: update CI/CD process to enable auto-release workflow (terraform-aws-modules#250) Updated CHANGELOG feat: Add security group egress rule support, fix documentation links (terraform-aws-modules#249) Updated CHANGELOG chore: Updated release Makefile Updated CHANGELOG BREAKING CHANGE: update module to allow for control over individual cluster instances and latest features (terraform-aws-modules#243) chore: update CI workflow to use composite actions, update pre-commit versions (terraform-aws-modules#242) Updated CHANGELOG feat: Add support for restore_to_point_in_time (terraform-aws-modules#194) ...
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
terraform_docs
hook which avoids pinning to exact version due to conflict of .terraform.lock.hcl file (Ignore extracting versions from terraform.lock.hcl terraform-docs/terraform-docs#527)Motivation and Context
Breaking Changes
How Has This Been Tested?