Fix for issue when MonitoringRoleARN is required (#140)

terraform-aws-modules · Jan 7, 2020 · 8861bf2 · 8861bf2
1 parent 5538025
commit 8861bf2
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/modules/db_instance/main.tf b/modules/db_instance/main.tf
@@ -52,7 +52,7 @@ resource "aws_db_instance" "this" {
   iops                = "${var.iops}"
   publicly_accessible = "${var.publicly_accessible}"
   monitoring_interval = "${var.monitoring_interval}"
-  monitoring_role_arn = "${coalesce(var.monitoring_role_arn, join("", aws_iam_role.enhanced_monitoring.*.arn))}"
+  monitoring_role_arn = "${var.monitoring_interval > 0 ? coalesce(var.monitoring_role_arn, join("", aws_iam_role.enhanced_monitoring.*.arn)) : "" }"
 
   allow_major_version_upgrade = "${var.allow_major_version_upgrade}"
   auto_minor_version_upgrade  = "${var.auto_minor_version_upgrade}"
@@ -115,7 +115,7 @@ resource "aws_db_instance" "this_mssql" {
   iops                = "${var.iops}"
   publicly_accessible = "${var.publicly_accessible}"
   monitoring_interval = "${var.monitoring_interval}"
-  monitoring_role_arn = "${coalesce(var.monitoring_role_arn, join("", aws_iam_role.enhanced_monitoring.*.arn))}"
+  monitoring_role_arn = "${var.monitoring_interval > 0 ? coalesce(var.monitoring_role_arn, join("", aws_iam_role.enhanced_monitoring.*.arn)) : "" }"
 
   allow_major_version_upgrade = "${var.allow_major_version_upgrade}"
   auto_minor_version_upgrade  = "${var.auto_minor_version_upgrade}"