Fix for issue when MonitoringRoleARN is required

[flmmartins]

Description

This fix issue #136 for terraform 0.12

PS: This has not being tested =( since in my infra I still use 0.11. It would be nice if someone could test

[ozbillwang]

No fix. I still get the error

module.db_instance.aws_db_instance.this[0]: Creating...

Error: Error creating DB Instance: InvalidParameterCombination: A MonitoringRoleARN value is required if you specify a MonitoringInterval value other than 0.
	status code: 400, request id: aeb9b125-e8fb-4290-a4e3-09d79502e5d7

[ozbillwang]

ok, seems you didn't set the same as v0.11 (#140 )

This code works with join() function

monitoring_role_arn = var.monitoring_interval > 0 ? coalesce(var.monitoring_role_arn, join(", ", aws_iam_role.enhanced_monitoring.*.arn), null) : null

[flmmartins]

I updated the code and added the join. @ozbillwang can you review again?

[ozbillwang]

yes, it works with mysql.

I didn't test with mssql. should be fine.

[antonbabenko]

Thanks, @flmmartins !

v2.12.0 has been released for Terraform 0.12 users.

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.