fix: documentation for default storage type #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saimonn
force-pushed
the
storage_type-description
branch
from
ef0fd96
to
f5fa540
Compare
saimonn
changed the title
saimonn
force-pushed
the
storage_type-description
branch
from
f5fa540
to
a13e88d
Compare
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I changed the doc to reflect reality on the storage_type variable.
Motivation and Context
The documentation is somewhat confusing, the description explains it defaults to "standard", and the field "default" of the table reads "gp2".
We had to read the code to guess the real default storage_type (gp2).
Breaking Changes
None.
How Has This Been Tested?
I read the doc after the change: it was not confusing anymore.