Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Improvement to main module documentation in regard to gp3 adoption #463

Conversation

etiennechabert
Copy link
Contributor

@etiennechabert etiennechabert commented Dec 19, 2022

Description

Motivation and Context

This reminder from @lucasvuotto: #456 (comment)

Breaking Changes

Just docs

How Has This Been Tested?

No tests done

@etiennechabert
Copy link
Contributor Author

etiennechabert commented Dec 19, 2022

Please do not merge before: #462

Both PRs are touching IOPS variable, I will merge master into this branch after the first PR is merged, and manage conflicts

Update: We are now good for merge 👍

@bryantbiggs bryantbiggs changed the title docs: improvement for main module in regards to gp3 docs: Improvement for main module in regards to gp3 Dec 20, 2022
@etiennechabert etiennechabert changed the title docs: Improvement for main module in regards to gp3 docs: Improvement to main module documentation in regard to gp3 adoption Dec 20, 2022
@etiennechabert
Copy link
Contributor Author

etiennechabert commented Dec 20, 2022

Sorry @bryantbiggs undid your change to the tittle... please put it back if you prefer yours

@bryantbiggs bryantbiggs merged commit baf54be into terraform-aws-modules:master Dec 20, 2022
@etiennechabert etiennechabert deleted the docs-improvement-for-main-module-in-regards-to-gp3 branch December 20, 2022 18:24
@antonbabenko
Copy link
Member

This PR is included in version 5.2.3 🎉

@github-actions
Copy link

github-actions bot commented Feb 3, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants