Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Pass through db_instance_master_user_secret_arn #502

Merged
merged 3 commits into from
Jul 11, 2023
Merged

feat: Pass through db_instance_master_user_secret_arn #502

merged 3 commits into from
Jul 11, 2023

Conversation

lwj
Copy link
Contributor

@lwj lwj commented Jun 26, 2023 •
edited by bryantbiggs
Loading

Description

Pass through aws_db_instance.this[0].master_user_secret[0].secret_arn to return the secret ARN when manage_master_user_password is set to true

Motivation and Context

Breaking Changes

None

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@lwj lwj changed the title feat: pass through db_instance_master_user_secret_arn feat: Pass through db_instance_master_user_secret_arn Jun 26, 2023
bryantbiggs
bryantbiggs approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@bryantbiggs bryantbiggs merged commit f0eb9f3 into terraform-aws-modules:master Jul 11, 2023
antonbabenko pushed a commit that referenced this pull request Jul 11, 2023
@semantic-release-bot
chore(release): version 6.1.0 [skip ci]
0ab79b0 
## [6.1.0](v6.0.0...v6.1.0) (2023-07-11)

### Features

* Pass through db_instance_master_user_secret_arn ([#502](#502)) ([f0eb9f3](f0eb9f3))
@antonbabenko
Copy link
Member

This PR is included in version 6.1.0 🎉

@lwj lwj deleted the feat/master_secret branch July 11, 2023 11:20
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add outputs for master_user_secret
4 participants
@lwj @antonbabenko @bryantbiggs @LJGamma