fix: Add upgrade doc and fix variable description #548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Minor comments to keep naming more consistent across other modules. LGTM but let @bryantbiggs review, too.
Co-authored-by: Anton Babenko <anton@antonbabenko.com>
bryantbiggs
approved these changes
Apr 22, 2024
antonbabenko
pushed a commit
that referenced
this pull request
Apr 22, 2024
## [6.5.5](v6.5.4...v6.5.5) (2024-04-22) ### Bug Fixes * Add upgrade doc and fix variable description ([#548](#548)) ([97f6261](97f6261))
|
This PR is included in version 6.5.5 🎉 |
|
thanks |
magreenbaum
deleted the
fix/add_upgrade_doc_and_fix_variable_description
branch
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide some additional clarification in the variable description and example comments for the use of
manage_master_user_password_rotation.Provide an upgrade doc for v6.
Motivation and Context
Breaking Changes
No. Only documentation addition/changes.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request