Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Updated S3 Bucket Block Public Access and ACL(Object Ownership) defaults to work since April 2023 #226

Merged
merged 3 commits into from
Apr 26, 2023
Merged

feat: Updated S3 Bucket Block Public Access and ACL(Object Ownership) defaults to work since April 2023 #226

merged 3 commits into from
Apr 26, 2023

Conversation

yoyoman21
Copy link
Contributor

@yoyoman21 yoyoman21 commented Apr 26, 2023 •
edited by antonbabenko
Loading

Description

Modified the Variables related to block s3 public access and changed the default value of Object Ownership according to latest aws s3 bucket update.

Motivation and Context

i)Need to change It due to the recent s3 bucket update by aws from April 2023.Following is the link describing the change from aws:- https://aws.amazon.com/blogs/aws/heads-up-amazon-s3-security-changes-are-coming-in-april-of-2023/

Fixes #223
Fixes #224

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@yoyoman21 yoyoman21 changed the title S3 Bucket Block Public Access and ACL(Object Ownership) -fix fix: S3 Bucket Block Public Access and ACL(Object Ownership) Apr 26, 2023
stephendayext
stephendayext approved these changes Apr 26, 2023
View reviewed changes
Copy link

@stephendayext stephendayext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wolfedale
Copy link

+1

@r1ddl3
Copy link

r1ddl3 commented Apr 26, 2023

@barryib @antonbabenko @dynamike @bryantbiggs Is someone who is a maintainer able to approve please?

@ferrarijefferson
Copy link

+1

@antonbabenko
Copy link
Member

I will look into this PR and the problem today (European time). Thank you for the PR!

@good92
Copy link

good92 commented Apr 26, 2023

hashicorp/terraform-provider-aws#28353 Notice: S3 - Changes to Defaults (Block Public Access and ACL's) - AccessControlListNotSupported: The bucket does not allow ACLs
https://docs.aws.amazon.com/AmazonS3/latest/userguide/about-object-ownership.html April 2023 changes on new S3 creation without ACLs → bucket policy

https://docs.aws.amazon.com/AmazonS3/latest/userguide/create-bucket-faq.html

stefan-matic
stefan-matic reviewed Apr 26, 2023
View reviewed changes
main.tf Outdated
Copy link

@stefan-matic stefan-matic Apr 26, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting issue. Run the pre-commit hooks to fix this and also update the example README files.

@stefan-matic
Copy link

There is still a matter of attach_policy throwing Error putting S3 policy: AccessDenied: Access Denied , which is probably related to the recent change. A workaround is explained in this comment.

@antonbabenko antonbabenko changed the title fix: S3 Bucket Block Public Access and ACL(Object Ownership) feat: Updated S3 Bucket Block Public Access and ACL(Object Ownership) defaults to work since April 2023 Apr 26, 2023
@antonbabenko antonbabenko merged commit 12ad5b6 into terraform-aws-modules:master Apr 26, 2023
antonbabenko pushed a commit that referenced this pull request Apr 26, 2023
@semantic-release-bot
chore(release): version 3.9.0 [skip ci]
d73535b 
## [3.9.0](v3.8.2...v3.9.0) (2023-04-26)

### Features

* Updated S3 Bucket Block Public Access and ACL(Object Ownership) defaults to work since April 2023 ([#226](#226)) ([12ad5b6](12ad5b6))
@antonbabenko
Copy link
Member

This PR is included in version 3.9.0 🎉

@jeffmaher jeffmaher mentioned this pull request Apr 27, 2023
Open
5 tasks
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stefan-matic stefan-matic stefan-matic left review comments

@stephendayext stephendayext stephendayext approved these changes

@ferrarijefferson ferrarijefferson ferrarijefferson approved these changes

@b13n1u b13n1u b13n1u approved these changes

@wolfedale wolfedale wolfedale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
9 participants
@yoyoman21 @wolfedale @r1ddl3 @ferrarijefferson @antonbabenko @good92 @stefan-matic @b13n1u @stephendayext