feat: Add default Access Log Delivery Policy (same as ALB/NLB) to work since April 2023 #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cageyv
changed the title
antonbabenko
approved these changes
Apr 27, 2023
examples/complete/main.tf
Outdated
| attach_deny_insecure_transport_policy = true | ||
| attach_require_latest_tls_policy = true | ||
|
|
||
| # Advanced options |
There was a problem hiding this comment.
I would not call this "advanced" :)
antonbabenko
pushed a commit
that referenced
this pull request
Apr 27, 2023
## [3.10.0](v3.9.0...v3.10.0) (2023-04-27) ### Features * Add default Access Log Delivery Policy (same as ALB/NLB) to work since April 2023 ([#230](#230)) ([bafac30](bafac30))
|
This PR is included in version 3.10.0 🎉 |
|
@cageyv Thank you for this PR! |
Jean717p
pushed a commit
to Jean717p/terraform-aws-s3-bucket
that referenced
this pull request
Apr 27, 2023
Jean717p
pushed a commit
to Jean717p/terraform-aws-s3-bucket
that referenced
this pull request
Apr 27, 2023
## [3.10.0](terraform-aws-modules/terraform-aws-s3-bucket@v3.9.0...v3.10.0) (2023-04-27) ### Features * Add default Access Log Delivery Policy (same as ALB/NLB) to work since April 2023 ([terraform-aws-modules#230](terraform-aws-modules#230)) ([bafac30](terraform-aws-modules@bafac30))
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create default Access Log Delivery Policy for migrate from grants according to latest aws s3 bucket update.
Motivation and Context
It will allow us to setup Bucket Policy for Access Log Delivery in the same way same as for ALB/NLB logs delivery. Policy was created by using that migration guide from AWS:
https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-ownership-migrating-acls-prerequisites.html#object-ownership-server-access-logs
It also support additional security conditions such as
aws:SourceArnandaws:SourceAccountwhich will helpful for someone who using cross-account log deliveryClose #229
Breaking Changes
How Has This Been Tested?
2023-04-27 12:57 UTC S3 Access Logs appears and policy is working
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request