feat: Added outputs for s3 bucket lifecycle rules and policy #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonbabenko
requested changes
May 25, 2023
outputs.tf
Outdated
|
|
||
| output "s3_bucket_policy" { | ||
| description = "The policy of the bucket, if the bucket is configured with a policy. If not, this will be an empty string." | ||
| value = try(jsondecode(aws_s3_bucket_policy.this[0].policy), "") |
There was a problem hiding this comment.
Suggested change
| value = try(jsondecode(aws_s3_bucket_policy.this[0].policy), "") | |
| value = try(aws_s3_bucket_policy.this[0].policy, "") |
outputs.tf
Outdated
| @@ -23,6 +23,16 @@ output "s3_bucket_hosted_zone_id" { | |||
| value = try(aws_s3_bucket.this[0].hosted_zone_id, "") | |||
| } | |||
|
|
|||
| output "s3_bucket_lifecycle_configuration_rules" { | |||
| description = "The lifecycle rules of the bucket, if the bucket is configured with lifecycle rules. If not, this will be an empty string." | |||
| value = try(jsondecode(jsonencode(aws_s3_bucket_lifecycle_configuration.this[0].rule)), "") | |||
There was a problem hiding this comment.
Suggested change
| value = try(jsondecode(jsonencode(aws_s3_bucket_lifecycle_configuration.this[0].rule)), "") | |
| value = try(aws_s3_bucket_lifecycle_configuration.this[0].rule, "") |
antonbabenko
changed the title
dhollerbach-nelnet
approved these changes
May 25, 2023
antonbabenko
approved these changes
May 25, 2023
antonbabenko
pushed a commit
that referenced
this pull request
May 25, 2023
## [3.11.0](v3.10.1...v3.11.0) (2023-05-25) ### Features * Added outputs for s3 bucket lifecycle rules and policy ([#234](#234)) ([24b88e8](24b88e8))
|
This PR is included in version 3.11.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR creates two new outputs: 1) a list of lifecycle rules applied to the s3 bucket and, 2) the policy applied to the s3 bucket. Each output is set to an empty string if its respective value is not provided.
Additionally, this PR removes the deprecated
skip_get_ec2_platformsargument from the aws providers in all examples directories.Motivation and Context
While creating tests for my own S3 modules, I ran into a trouble when trying to validate lifecycle rules and policies applied to my S3 bucket. I was able to output the
data_iam_policy_documenteasily enough but lifecycle rules are not available as a data source. My workaround was configuring the proper result in Go itself but it would be much better to output these values in case anyone wants to use them; for tests in my case.Additionally, while running the pre-commit for these outputs, the validations were failing because the
skip_get_ec2_platformsargument is not longer supported using Terraform version 1.4.5, the version used to perform all tests. To pass all validation checks, theskip_get_ec2_platformsargument was removed from the following examples directories:Breaking Changes
No.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request