feat: support a list of CORS rules instead of a single rule #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exocom
changed the title
exocom
changed the title
exocom
force-pushed
the
multiple-cors-rules
branch
from
dd2d59d
to
c591b95
Compare
bryantbiggs
reviewed
Aug 9, 2020
exocom
force-pushed
the
multiple-cors-rules
branch
from
c591b95
to
446d754
Compare
|
@bryantbiggs any chance we can get this merged in? |
|
I renamed variable to be the same as before - |
antonbabenko
changed the title
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modify CORS to support multiple rules instead of a single rule
Motivation and Context
When importing an existing bucket the module was attempting to remove all but one of the rules.
Breaking Changes
Yes
Object to Array. It is possible to be backwards compatible, however, since the syntax is as simple as adding brackets there is little reason to add additional code.
How Has This Been Tested?
Applying on an existing resource