fix: Declare data resource only for requested VPC endpoints (#800)

terraform-aws-modules · Jun 16, 2022 · 024fbc0 · 024fbc0
1 parent 41da688
commit 024fbc0
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/modules/vpc-endpoints/main.tf b/modules/vpc-endpoints/main.tf
@@ -2,8 +2,12 @@
 # Endpoint(s)
 ################################################################################
 
+locals {
+  endpoints = { for k, v in var.endpoints : k => v if var.create && try(v.create, true) }
+}
+
 data "aws_vpc_endpoint_service" "this" {
-  for_each = { for k, v in var.endpoints : k => v if var.create }
+  for_each = local.endpoints
 
   service      = lookup(each.value, "service", null)
   service_name = lookup(each.value, "service_name", null)
@@ -15,7 +19,7 @@ data "aws_vpc_endpoint_service" "this" {
 }
 
 resource "aws_vpc_endpoint" "this" {
-  for_each = { for k, v in var.endpoints : k => v if var.create && try(v.create, true) }
+  for_each = local.endpoints
 
   vpc_id            = var.vpc_id
   service_name      = data.aws_vpc_endpoint_service.this[each.key].service_name