Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow setting vpc endpoints as an input for each endpoint #1056

Merged
merged 2 commits into from
Mar 22, 2024
Merged

feat: Allow setting vpc endpoints as an input for each endpoint #1056

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
38c3c88
feat: allow setting vpc endpoints as an input for each endpoint
zack-is-cool Mar 22, 2024
2c95da6
naming
zack-is-cool Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/vpc-endpoints/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ resource "aws_vpc_endpoint" "this" {
for_each = local.endpoints

vpc_id = var.vpc_id
service_name = data.aws_vpc_endpoint_service.this[each.key].service_name
service_name = try(each.value.service_endpoint_url, data.aws_vpc_endpoint_service.this[each.key].service_name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How service_endpoint_url should look for the FIPS environment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I wasn't clear on this, I meant more so in the context of since you can override with inputs, users can use fips endpoints

see:
https://github.com/defenseunicorns/terraform-aws-vpc/pull/113/files#diff-dc46acf24afd63ef8c556b77c126ccc6e578bc87e3aa09a931f33d9bf2532fbbR227

You'd probably able to do it with this module if we added another data "aws_vpc_endpoint_service" with different filters, but It doesn't seem like a super common enough request.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I think it should be named service_endpoint instead of service_endpoint_url to represent the actual type of the expected value. Could you change it and I will merge it? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, no problem.

vpc_endpoint_type = try(each.value.service_type, "Interface")
auto_accept = try(each.value.auto_accept, null)

Expand Down