fix: NAT gw route table associations shouldn't be created when enable_nat_gateway=false #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eway=false Fixes the issue described terraform-aws-modules#1031
kkonstant-in
changed the title
kkonstant-in
changed the title
3 tasks
|
Hi there. @bryantbiggs do you need a more detailed description or anything else for this issue? |
|
Hi, any updates? |
|
This PR has been automatically marked as stale because it has been open 30 days |
|
Hi, any updates? |
|
Hi, any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes creating NAT gateway route table associations even when enable_nat_gateway=false
Motivation and Context
More detailed description of the issue is here #1031
Breaking Changes
no breaking changes
How Has This Been Tested?
Tested in production TGW environment with no NAT gw route table associations