Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cidr_block outputs to public and private subnets #19

Merged
merged 5 commits into from
Nov 3, 2017

Conversation

ChairmanTubeAmp
Copy link
Contributor

No description provided.

@antonbabenko
Copy link
Member

Please add the same for database and elasticache subnets.

Martin Beauchamp added 2 commits November 3, 2017 16:05
* 'master' of github.com:Shapeways/terraform-aws-vpc:
  Add AZ to natgateway name
  NAT gateway should be tagged too.
  Make aws_vpc_endpoint_service conditional
@ChairmanTubeAmp
Copy link
Contributor Author

added database and elasticache subnets

@antonbabenko antonbabenko merged commit 1cdd000 into terraform-aws-modules:master Nov 3, 2017
@antonbabenko
Copy link
Member

Thank you!

lorengordon pushed a commit to lorengordon/terraform-aws-vpc that referenced this pull request Nov 9, 2017
ChairmanTubeAmp pushed a commit to Shapeways/terraform-aws-vpc that referenced this pull request Nov 28, 2017
* 'master' of github.com:Shapeways/terraform-aws-vpc:
  Reverted bad merge, fixed terraform-aws-modules#33
  Set enable_dns_support=true by default
  Updated descriptions for DNS variables (closes terraform-aws-modules#14)
  Add version requirements in README.md (fixes terraform-aws-modules#32)
  Add version requirements in README.md
  make sure outputs are always valid (terraform-aws-modules#29)
  Add tags to the aws_vpc_dhcp_options resource (terraform-aws-modules#30)
  Add support for DHCP options set (terraform-aws-modules#20)
  terraform-aws-modules#22 add vpn gateway feature (terraform-aws-modules#24)
  Add cidr_block outputs to public and private subnets (terraform-aws-modules#19)
@github-actions
Copy link

github-actions bot commented Nov 6, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants