Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Enable support for Terraform 0.13 as a valid version by setting minimum version required #455

Merged
merged 2 commits into from
Jun 6, 2020
Merged

feat: Enable support for Terraform 0.13 as a valid version by setting minimum version required #455

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcfdec5
feat: enable 0.13 as a valid version by setting minimum version required
bryantbiggs Jun 5, 2020
12cac22
- Add upper bound limit to version
bryantbiggs Jun 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion versions.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
terraform {
required_version = "~> 0.12.6"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is too optimistic that things won't break in 0.14 :)

Instead, can you write something like ~> 0.12.6 || ~> 0.13.0 (I didn't test this) ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. I can add an upper-bounds to allow up to but not including 0.14 (similiar to what you wrote) https://www.terraform.io/docs/configuration/terraform.html#specifying-a-required-terraform-version

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am thinking about this - ~> 0.12.6, ~> 0.13.0. The point is that in 0.13.x may be something wrong and we may want to add another excluding range after a comma.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok give me some time to do a quick test to see if that style works, I can't tell for sure from just reading the docs. I'll get back to you

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok so the syntax you've proposed is not valid - the closest equivalent is what I have proposed in this PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, good to know. Merging.

required_version = ">= 0.12.6, < 0.14"

required_providers {
aws = "~> 2.53"
Expand Down