Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore changes to propagating_vgws of private routing table #50

Conversation

miguelaferreira
Copy link
Contributor

This PR makes the routing tables for the private subnets ignore changes to their propagating_vgws.

When configuring VPN Gateways it is normal to define aws_vpn_gateway_route_propagation resources to automatically configure route propagation between the VPN Gateway and a routing table. However, without this PR, terraform will continuously propose changes to the infrastructure, adding route propagation in one run and removing it the next.

First run:

Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  + aws_vpn_gateway_route_propagation.private_subnets_vpn_routing[0]
      id:             <computed>
      route_table_id: "rtb-aaa"
      vpn_gateway_id: "vgw-xxx"

  + aws_vpn_gateway_route_propagation.private_subnets_vpn_routing[1]
      id:             <computed>
      route_table_id: "rtb-bbb"
      vpn_gateway_id: "vgw-xxx"

Second run:

Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  ~ module.vpc.aws_route_table.private[0]
      propagating_vgws.#:          "1" => "0"
      propagating_vgws.3028428753: "vgw-xxx" => ""

  ~ module.vpc.aws_route_table.private[1]
      propagating_vgws.#:          "1" => "0"
      propagating_vgws.3028428753: "vgw-xxx" => ""

@antonbabenko antonbabenko merged commit ed3b426 into terraform-aws-modules:master Jan 3, 2018
@antonbabenko
Copy link
Member

Thanks for this PR, v1.13.0 is released

@github-actions
Copy link

github-actions bot commented Nov 6, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants