fix: don't impersonante users #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khos2ow
reviewed
May 19, 2021
Comment on lines
+57
to
+58
| | git-push-user-email | If empty the no-reply email of the GitHub Actions bot will be used (i.e. `github-actions[bot]@users.noreply.github.com`) | `""` | false | | ||
| | git-push-user-name | If empty the name of the GitHub Actions bot will be used (i.e. `github-actions[bot]`) | `""` | false | |
There was a problem hiding this comment.
This table is auto-generated using the content of action.yml. Please update the action file and run ./scripts/update-readme.sh (which in this case shouldn't change README any further)
There was a problem hiding this comment.
Done, didn't know about that
Signed-off-by: Leah <github.leah@hrmny.sh>
khos2ow
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Impersonating the commit author of the previous commit to me is unexpected and unwanted behaviour, it's a GitHub Action, so committing via the bot user makes more sense to me
I have:
How has this code been tested
don't know how I'd test it