Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uniform_bucket_level_access instead of deprecated bucket_policy_only #82

Conversation

slavaaaaaaaaaa
Copy link

Resolves #79

@slavaaaaaaaaaa
Copy link
Author

Oops, already done via #80

@comment-bot-dev
Copy link

Thanks for the PR! 🚀
Unfortunately it looks like some of our CI checks failed. See the Contributing Guide for details.

  • ⚠️check_documentation
    The documentation needs to be regenerated. Please run make generate_docs.
Checking for documentation generation
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/terraform-google-cloud-storage/README.md /tmp/tmp.edbruOxoa6/generate_docs/workspace/terraform-google-cloud-storage/README.md
52d51
< | uniform\_bucket\_level\_access | Disable ad-hoc ACLs on specified buckets. Defaults to true. Map of lowercase unprefixed name => boolean | map | `<map>` | no |
68a68
> | uniform\_bucket\_level\_access | Disable ad-hoc ACLs on specified buckets. Defaults to true. Map of lowercase unprefixed name => boolean | map | `<map>` | no |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/terraform-google-cloud-storage/examples/multiple_buckets/README.md /tmp/tmp.edbruOxoa6/generate_docs/workspace/terraform-google-cloud-storage/examples/multiple_buckets/README.md
10d9
< | bucket\_policy\_only | Disable ad-hoc ACLs on specified buckets. Defaults to true. Map of lowercase unprefixed name => boolean | map(string) | `<map>` | no |
13a13
> | uniform\_bucket\_level\_access | Disable ad-hoc ACLs on specified buckets. Defaults to true. Map of lowercase unprefixed name => boolean | map(string) | `<map>` | no |
diff -r '--exclude=.terraform' '--exclude=.kitchen' '--exclude=.git' '--exclude=autogen' '--exclude=*.tfvars' /workspace/terraform-google-cloud-storage/modules/simple_bucket/README.md /tmp/tmp.edbruOxoa6/generate_docs/workspace/terraform-google-cloud-storage/modules/simple_bucket/README.md
41d40
< | bucket\_policy\_only | Enables Bucket Policy Only access to a bucket. | bool | `"true"` | no |
51a51
> | uniform\_bucket\_level\_access | Enables Uniform bucket-level access to a bucket. | bool | `"true"` | no |
Error: Documentation generation has not been run, please run the
'make docker_generate_docs' command and commit the above changes.
  • ⚠️check_terraform
    Failed Terraform check. More details below.
Running terraform fmt
modules/simple_bucket/main.tf
--- old/modules/simple_bucket/main.tf
+++ new/modules/simple_bucket/main.tf
@@ -15,13 +15,13 @@
 */

resource "google_storage_bucket" "bucket" {
-  name               = var.name
-  project            = var.project_id
-  location           = var.location
-  storage_class      = var.storage_class
+  name                        = var.name
+  project                     = var.project_id
+  location                    = var.location
+  storage_class               = var.storage_class
  uniform_bucket_level_access = var.uniform_bucket_level_access
-  labels             = var.labels
-  force_destroy      = var.force_destroy
+  labels                      = var.labels
+  force_destroy               = var.force_destroy

  versioning {
    enabled = var.versioning
Error: terraform fmt failed with exit code 3
Check the output for diffs and correct using terraform fmt <dir>

@slavaaaaaaaaaa slavaaaaaaaaaa deleted the fix/uniform_bucket_level_access branch September 16, 2020 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Google provider v3
2 participants