use for_each instead of count to create resource

[adrian-gierakowski]

This prevents unnencesary recreation of resources when content/order of the
names list changes.

Addresses issue mentioned in: https://github.com/terraform-google-modules/cloud-foundation-fabric/tree/73b7613cc062491305ebfabf8a8b1db0c53fc55b/foundations#things-to-be-aware-of

[comment-bot-dev]

Thanks for the PR! 🚀
✅ Lint checks have passed.

[adrian-gierakowski]

running integration tests locally but it's taking a long time as I'm seeing the following:

module.project.module.project-factory.module.gcloud_disable.null_resource.upgrade[0] (local-exec): Your current Cloud SDK version is: 281.0.0
module.project.module.project-factory.module.gcloud_disable.null_resource.upgrade[0] (local-exec): You will be upgraded to version: 310.0.0

Since the docker image from which the tests are ran already comes with gcloud pre-installed it would be nice if the installed version was sufficient to avoid the extra download during a test run

[morgante]

@adrian-gierakowski Newer versions avoid that.

This is the error in tests:

       Error: Incorrect attribute value type
       
         on ../../../main.tf line 158, in resource "google_storage_bucket_object" "folders":
        158:   bucket   = google_storage_bucket.buckets[each.value.bucket]
           |----------------
           | each.value.bucket is "two"
           | google_storage_bucket.buckets is object with 2 attributes
       
       Inappropriate value for attribute "bucket": string required.

[adrian-gierakowski]

@morgante integration tests are now passing, not sure about the other 2 jobs

[morgante]

Thank you for adding this.

[morgante]

Before release, we'll also need an upgrade guide / script added like this one.