Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add debug options and bump arg num check kubectl wrapper #79

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

jaketf
Copy link
Contributor

@jaketf jaketf commented Sep 11, 2020

The arg number check does not match the shift number in the script which leads to confusing user failures.
Also we can fail faster and log more verbosely to help others debug similar situations easier in the future.
context:
terraform-google-modules/terraform-google-kubernetes-engine#666 (comment)

@comment-bot-dev
Copy link

Thanks for the PR! 🚀
✅ Lint checks have passed.

@jaketf
Copy link
Contributor Author

jaketf commented Sep 11, 2020

R: @bharathkkb

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@bharathkkb bharathkkb changed the title Add debug options and bump arg num check kubectl wrapper fix: Add debug options and bump arg num check kubectl wrapper Sep 11, 2020
@bharathkkb bharathkkb merged commit a82559e into terraform-google-modules:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants