Skip to content

Commit

Permalink
Added add'l describe block, quoted bools
Browse files Browse the repository at this point in the history
  • Loading branch information
coryodaniel committed Jan 8, 2019
1 parent 1a81626 commit 028a6f1
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 6 deletions.
13 changes: 9 additions & 4 deletions test/integration/disable_client_cert/controls/gcloud.rb
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,15 @@
expect(data['masterAuth']['clientCertificate']).to be_nil
end

it "does not have a basic auth enabled" do
expect(data['masterAuth']['username']).to be_nil
expect(data['masterAuth']['password']).to be_nil
describe "does not have a basic auth enabled" do
it "username is nil" do
expect(data['masterAuth']['username']).to be_nil
end

it "password is nil" do
expect(data['masterAuth']['password']).to be_nil
end
end
end
end
end
end
4 changes: 2 additions & 2 deletions variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ variable "service_account" {

variable "enable_basic_auth" {
description = "Basic authentication allows a user to authenticate to the cluster with a username and password. To maximize the security of your cluster, disable this option. Basic authentication is not recommended because it provides no confidentiality protection for transmitted credentials"
default = true
default = "true"
}

variable "basic_auth_username" {
Expand All @@ -217,5 +217,5 @@ variable "basic_auth_password" {

variable "issue_client_certificate" {
description = "Issues a client certificate to authenticate to the cluster endpoint. To maximize the security of your cluster, leave this option disabled. Client certificates don't automatically rotate and aren't easily revocable. WARNING: changing this after cluster creation is destructive!"
default = false
default = "false"
}

0 comments on commit 028a6f1

Please sign in to comment.