Skip to content

Commit

Permalink
feat: Add filestore_csi_driver option for safer cluster variants (#…
Browse files Browse the repository at this point in the history
…1176)

Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
  • Loading branch information
lauraseidler and bharathkkb committed Apr 12, 2022
1 parent 81d3fa1 commit 40ef1a1
Show file tree
Hide file tree
Showing 8 changed files with 26 additions and 3 deletions.
3 changes: 2 additions & 1 deletion autogen/safer-cluster/main.tf.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,8 @@ module "gke" {

skip_provisioners = var.skip_provisioners

gce_pd_csi_driver = var.gce_pd_csi_driver
gce_pd_csi_driver = var.gce_pd_csi_driver
filestore_csi_driver = var.filestore_csi_driver

notification_config_topic = var.notification_config_topic
}
6 changes: 6 additions & 0 deletions autogen/safer-cluster/variables.tf.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,12 @@ variable "gce_pd_csi_driver" {
default = true
}

variable "filestore_csi_driver" {
type = bool
description = "The status of the Filestore CSI driver addon, which allows the usage of filestore instance as volumes"
default = false
}

variable "add_cluster_firewall_rules" {
type = bool
description = "Create additional firewall rules"
Expand Down
1 change: 1 addition & 0 deletions modules/safer-cluster-update-variant/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ For simplicity, we suggest using `roles/container.admin` and
| enable\_resource\_consumption\_export | Whether to enable resource consumption metering on this cluster. When enabled, a table will be created in the resource export BigQuery dataset to store resource consumption data. The resulting table can be joined with the resource usage table or with BigQuery billing export. | `bool` | `true` | no |
| enable\_shielded\_nodes | Enable Shielded Nodes features on all nodes in this cluster. | `bool` | `true` | no |
| enable\_vertical\_pod\_autoscaling | Vertical Pod Autoscaling automatically adjusts the resources of pods controlled by it | `bool` | `false` | no |
| filestore\_csi\_driver | The status of the Filestore CSI driver addon, which allows the usage of filestore instance as volumes | `bool` | `false` | no |
| firewall\_inbound\_ports | List of TCP ports for admission/webhook controllers | `list(string)` | <pre>[<br> "8443",<br> "9443",<br> "15017"<br>]</pre> | no |
| firewall\_priority | Priority rule for firewall rules | `number` | `1000` | no |
| gce\_pd\_csi\_driver | (Beta) Whether this cluster should enable the Google Compute Engine Persistent Disk Container Storage Interface (CSI) Driver. | `bool` | `true` | no |
Expand Down
3 changes: 2 additions & 1 deletion modules/safer-cluster-update-variant/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,8 @@ module "gke" {

skip_provisioners = var.skip_provisioners

gce_pd_csi_driver = var.gce_pd_csi_driver
gce_pd_csi_driver = var.gce_pd_csi_driver
filestore_csi_driver = var.filestore_csi_driver

notification_config_topic = var.notification_config_topic
}
6 changes: 6 additions & 0 deletions modules/safer-cluster-update-variant/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,12 @@ variable "gce_pd_csi_driver" {
default = true
}

variable "filestore_csi_driver" {
type = bool
description = "The status of the Filestore CSI driver addon, which allows the usage of filestore instance as volumes"
default = false
}

variable "add_cluster_firewall_rules" {
type = bool
description = "Create additional firewall rules"
Expand Down
1 change: 1 addition & 0 deletions modules/safer-cluster/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ For simplicity, we suggest using `roles/container.admin` and
| enable\_resource\_consumption\_export | Whether to enable resource consumption metering on this cluster. When enabled, a table will be created in the resource export BigQuery dataset to store resource consumption data. The resulting table can be joined with the resource usage table or with BigQuery billing export. | `bool` | `true` | no |
| enable\_shielded\_nodes | Enable Shielded Nodes features on all nodes in this cluster. | `bool` | `true` | no |
| enable\_vertical\_pod\_autoscaling | Vertical Pod Autoscaling automatically adjusts the resources of pods controlled by it | `bool` | `false` | no |
| filestore\_csi\_driver | The status of the Filestore CSI driver addon, which allows the usage of filestore instance as volumes | `bool` | `false` | no |
| firewall\_inbound\_ports | List of TCP ports for admission/webhook controllers | `list(string)` | <pre>[<br> "8443",<br> "9443",<br> "15017"<br>]</pre> | no |
| firewall\_priority | Priority rule for firewall rules | `number` | `1000` | no |
| gce\_pd\_csi\_driver | (Beta) Whether this cluster should enable the Google Compute Engine Persistent Disk Container Storage Interface (CSI) Driver. | `bool` | `true` | no |
Expand Down
3 changes: 2 additions & 1 deletion modules/safer-cluster/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,8 @@ module "gke" {

skip_provisioners = var.skip_provisioners

gce_pd_csi_driver = var.gce_pd_csi_driver
gce_pd_csi_driver = var.gce_pd_csi_driver
filestore_csi_driver = var.filestore_csi_driver

notification_config_topic = var.notification_config_topic
}
6 changes: 6 additions & 0 deletions modules/safer-cluster/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,12 @@ variable "gce_pd_csi_driver" {
default = true
}

variable "filestore_csi_driver" {
type = bool
description = "The status of the Filestore CSI driver addon, which allows the usage of filestore instance as volumes"
default = false
}

variable "add_cluster_firewall_rules" {
type = bool
description = "Create additional firewall rules"
Expand Down

0 comments on commit 40ef1a1

Please sign in to comment.