Skip to content

Commit

Permalink
fix: Remove data google_client_config from all modules as it is no lo…
Browse files Browse the repository at this point in the history
…nger used within modules (#875)

* remove data google_client_config from all modules as it is no longer used within modules

* remove all auth files marked by autogen

* remove what I think is unnecessary dependencies on data field
  • Loading branch information
yashbhutwala committed Apr 29, 2021
1 parent 8a5dcb8 commit 687dc71
Show file tree
Hide file tree
Showing 24 changed files with 0 additions and 236 deletions.
24 changes: 0 additions & 24 deletions auth.tf

This file was deleted.

28 changes: 0 additions & 28 deletions autogen/main/auth.tf.tmpl

This file was deleted.

4 changes: 0 additions & 4 deletions autogen/main/dns.tf.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ module "gcloud_delete_default_kube_dns_configmap" {
kubectl_destroy_command = ""

module_depends_on = concat(
[data.google_client_config.default.access_token],
[google_container_cluster.primary.master_version],
[for pool in google_container_node_pool.pools : pool.name]
)
Expand Down Expand Up @@ -62,7 +61,6 @@ EOF

depends_on = [
module.gcloud_delete_default_kube_dns_configmap.wait,
data.google_client_config.default,
google_container_cluster.primary,
google_container_node_pool.pools,
]
Expand All @@ -89,7 +87,6 @@ EOF

depends_on = [
module.gcloud_delete_default_kube_dns_configmap.wait,
data.google_client_config.default,
google_container_cluster.primary,
google_container_node_pool.pools,
]
Expand Down Expand Up @@ -119,7 +116,6 @@ EOF

depends_on = [
module.gcloud_delete_default_kube_dns_configmap.wait,
data.google_client_config.default,
google_container_cluster.primary,
google_container_node_pool.pools,
]
Expand Down
1 change: 0 additions & 1 deletion autogen/main/masq.tf.tmpl
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ EOF
}

depends_on = [
data.google_client_config.default,
google_container_cluster.primary,
google_container_node_pool.pools,
]
Expand Down
4 changes: 0 additions & 4 deletions dns.tf
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ module "gcloud_delete_default_kube_dns_configmap" {
kubectl_destroy_command = ""

module_depends_on = concat(
[data.google_client_config.default.access_token],
[google_container_cluster.primary.master_version],
[for pool in google_container_node_pool.pools : pool.name]
)
Expand Down Expand Up @@ -62,7 +61,6 @@ EOF

depends_on = [
module.gcloud_delete_default_kube_dns_configmap.wait,
data.google_client_config.default,
google_container_cluster.primary,
google_container_node_pool.pools,
]
Expand All @@ -89,7 +87,6 @@ EOF

depends_on = [
module.gcloud_delete_default_kube_dns_configmap.wait,
data.google_client_config.default,
google_container_cluster.primary,
google_container_node_pool.pools,
]
Expand Down Expand Up @@ -119,7 +116,6 @@ EOF

depends_on = [
module.gcloud_delete_default_kube_dns_configmap.wait,
data.google_client_config.default,
google_container_cluster.primary,
google_container_node_pool.pools,
]
Expand Down
1 change: 0 additions & 1 deletion masq.tf
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ EOF
}

depends_on = [
data.google_client_config.default,
google_container_cluster.primary,
google_container_node_pool.pools,
]
Expand Down
24 changes: 0 additions & 24 deletions modules/beta-private-cluster-update-variant/auth.tf

This file was deleted.

4 changes: 0 additions & 4 deletions modules/beta-private-cluster-update-variant/dns.tf
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ module "gcloud_delete_default_kube_dns_configmap" {
kubectl_destroy_command = ""

module_depends_on = concat(
[data.google_client_config.default.access_token],
[google_container_cluster.primary.master_version],
[for pool in google_container_node_pool.pools : pool.name]
)
Expand Down Expand Up @@ -62,7 +61,6 @@ EOF

depends_on = [
module.gcloud_delete_default_kube_dns_configmap.wait,
data.google_client_config.default,
google_container_cluster.primary,
google_container_node_pool.pools,
]
Expand All @@ -89,7 +87,6 @@ EOF

depends_on = [
module.gcloud_delete_default_kube_dns_configmap.wait,
data.google_client_config.default,
google_container_cluster.primary,
google_container_node_pool.pools,
]
Expand Down Expand Up @@ -119,7 +116,6 @@ EOF

depends_on = [
module.gcloud_delete_default_kube_dns_configmap.wait,
data.google_client_config.default,
google_container_cluster.primary,
google_container_node_pool.pools,
]
Expand Down
1 change: 0 additions & 1 deletion modules/beta-private-cluster-update-variant/masq.tf
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ EOF
}

depends_on = [
data.google_client_config.default,
google_container_cluster.primary,
google_container_node_pool.pools,
]
Expand Down
24 changes: 0 additions & 24 deletions modules/beta-private-cluster/auth.tf

This file was deleted.

4 changes: 0 additions & 4 deletions modules/beta-private-cluster/dns.tf
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ module "gcloud_delete_default_kube_dns_configmap" {
kubectl_destroy_command = ""

module_depends_on = concat(
[data.google_client_config.default.access_token],
[google_container_cluster.primary.master_version],
[for pool in google_container_node_pool.pools : pool.name]
)
Expand Down Expand Up @@ -62,7 +61,6 @@ EOF

depends_on = [
module.gcloud_delete_default_kube_dns_configmap.wait,
data.google_client_config.default,
google_container_cluster.primary,
google_container_node_pool.pools,
]
Expand All @@ -89,7 +87,6 @@ EOF

depends_on = [
module.gcloud_delete_default_kube_dns_configmap.wait,
data.google_client_config.default,
google_container_cluster.primary,
google_container_node_pool.pools,
]
Expand Down Expand Up @@ -119,7 +116,6 @@ EOF

depends_on = [
module.gcloud_delete_default_kube_dns_configmap.wait,
data.google_client_config.default,
google_container_cluster.primary,
google_container_node_pool.pools,
]
Expand Down
1 change: 0 additions & 1 deletion modules/beta-private-cluster/masq.tf
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ EOF
}

depends_on = [
data.google_client_config.default,
google_container_cluster.primary,
google_container_node_pool.pools,
]
Expand Down
24 changes: 0 additions & 24 deletions modules/beta-public-cluster-update-variant/auth.tf

This file was deleted.

4 changes: 0 additions & 4 deletions modules/beta-public-cluster-update-variant/dns.tf
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ module "gcloud_delete_default_kube_dns_configmap" {
kubectl_destroy_command = ""

module_depends_on = concat(
[data.google_client_config.default.access_token],
[google_container_cluster.primary.master_version],
[for pool in google_container_node_pool.pools : pool.name]
)
Expand Down Expand Up @@ -62,7 +61,6 @@ EOF

depends_on = [
module.gcloud_delete_default_kube_dns_configmap.wait,
data.google_client_config.default,
google_container_cluster.primary,
google_container_node_pool.pools,
]
Expand All @@ -89,7 +87,6 @@ EOF

depends_on = [
module.gcloud_delete_default_kube_dns_configmap.wait,
data.google_client_config.default,
google_container_cluster.primary,
google_container_node_pool.pools,
]
Expand Down Expand Up @@ -119,7 +116,6 @@ EOF

depends_on = [
module.gcloud_delete_default_kube_dns_configmap.wait,
data.google_client_config.default,
google_container_cluster.primary,
google_container_node_pool.pools,
]
Expand Down
1 change: 0 additions & 1 deletion modules/beta-public-cluster-update-variant/masq.tf
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ EOF
}

depends_on = [
data.google_client_config.default,
google_container_cluster.primary,
google_container_node_pool.pools,
]
Expand Down
24 changes: 0 additions & 24 deletions modules/beta-public-cluster/auth.tf

This file was deleted.

4 changes: 0 additions & 4 deletions modules/beta-public-cluster/dns.tf
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ module "gcloud_delete_default_kube_dns_configmap" {
kubectl_destroy_command = ""

module_depends_on = concat(
[data.google_client_config.default.access_token],
[google_container_cluster.primary.master_version],
[for pool in google_container_node_pool.pools : pool.name]
)
Expand Down Expand Up @@ -62,7 +61,6 @@ EOF

depends_on = [
module.gcloud_delete_default_kube_dns_configmap.wait,
data.google_client_config.default,
google_container_cluster.primary,
google_container_node_pool.pools,
]
Expand All @@ -89,7 +87,6 @@ EOF

depends_on = [
module.gcloud_delete_default_kube_dns_configmap.wait,
data.google_client_config.default,
google_container_cluster.primary,
google_container_node_pool.pools,
]
Expand Down Expand Up @@ -119,7 +116,6 @@ EOF

depends_on = [
module.gcloud_delete_default_kube_dns_configmap.wait,
data.google_client_config.default,
google_container_cluster.primary,
google_container_node_pool.pools,
]
Expand Down
1 change: 0 additions & 1 deletion modules/beta-public-cluster/masq.tf
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ EOF
}

depends_on = [
data.google_client_config.default,
google_container_cluster.primary,
google_container_node_pool.pools,
]
Expand Down
Loading

0 comments on commit 687dc71

Please sign in to comment.