fix: allow ACM module to work w/o metrics sa (#1634)

terraform-google-modules · May 16, 2023 · 83a8be2 · 83a8be2
1 parent ea3e374
commit 83a8be2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/modules/acm/creds.tf b/modules/acm/creds.tf
@@ -107,6 +107,7 @@ resource "google_service_account" "acm_metrics_writer_sa" {
 }
 
 resource "google_project_iam_member" "acm_metrics_writer_sa_role" {
+  count   = var.create_metrics_gcp_sa ? 1 : 0
   project = var.project_id
   role    = "roles/monitoring.metricWriter"
   member  = "serviceAccount:${google_service_account.acm_metrics_writer_sa[0].email}"

diff --git a/modules/acm/outputs.tf b/modules/acm/outputs.tf
@@ -34,5 +34,5 @@ output "wait" {
 
 output "acm_metrics_writer_sa" {
   description = "The ACM metrics writer Service Account"
-  value       = google_service_account.acm_metrics_writer_sa[0].email
+  value       = var.create_metrics_gcp_sa ? google_service_account.acm_metrics_writer_sa[0].email : null
 }