Skip to content

Commit

Permalink
fix: update ASM mode var description (#910)
Browse files Browse the repository at this point in the history
* update key_file variable name and upgrade mode

* revert key_file rename

Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Co-authored-by: Morgante Pell <morgantep@google.com>
  • Loading branch information
3 people committed Jun 25, 2021
1 parent 0c5f363 commit a9be73c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion modules/asm/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ To deploy this config:
| key\_file | The GCP Service Account credentials file path used to deploy ASM. | `string` | `""` | no |
| location | The location (zone or region) this cluster has been created in. | `string` | n/a | yes |
| managed\_control\_plane | ASM managed control plane boolean. Determines whether to install ASM managed control plane. Installing ASM managed control plane does not install gateways. Documentation on how to install gateways with ASM MCP can be found at https://cloud.google.com/service-mesh/docs/managed-control-plane#install_istio_gateways_optional. | `bool` | `false` | no |
| mode | ASM mode for deployment. Supported mode is `install` only. | `string` | `"install"` | no |
| mode | ASM mode for deployment. Supported modes are `install` and `upgrade`. | `string` | `"install"` | no |
| options | Comma separated list of options. Works with in-cluster control plane only. Supported options are documented in https://cloud.google.com/service-mesh/docs/enable-optional-features. | `list` | `[]` | no |
| outdir | Sets `--outdir` option. | `string` | `"none"` | no |
| project\_id | The project in which the resource belongs. | `string` | n/a | yes |
Expand Down
2 changes: 1 addition & 1 deletion modules/asm/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ variable "asm_git_tag" {
}

variable "mode" {
description = "ASM mode for deployment. Supported mode is `install` only."
description = "ASM mode for deployment. Supported modes are `install` and `upgrade`."
type = string
default = "install"
}
Expand Down

0 comments on commit a9be73c

Please sign in to comment.