variable validation: || does not short-circuit

terraform-google-modules · Jan 3, 2024 · eeca156 · eeca156
1 parent 87ee18d
commit eeca156
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/modules/workload-identity/variables.tf b/modules/workload-identity/variables.tf
@@ -121,7 +121,7 @@ variable "gcp_sa_display_name" {
   default     = null
 
   validation {
-    condition     = length(var.gcp_sa_display_name) <= 100
+    condition     = var.gcp_sa_display_name == null ? true : length(var.gcp_sa_display_name) <= 100
     error_message = "The Google service account display name must be at most 100 characters"
   }
 }
@@ -133,7 +133,7 @@ variable "gcp_sa_description" {
   default     = null
 
   validation {
-    condition     = length(var.gcp_sa_description) <= 256
+    condition     = var.gcp_sa_description == null ? true : length(var.gcp_sa_description) <= 256
     error_message = "The Google service account display name must be at most 100 characters"
   }
 }