Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workload-identity module with use_existing_gcp_sa and gcp_sa_name set #1002

Closed
msonnleitner opened this issue Sep 17, 2021 · 1 comment · Fixed by #1003
Closed

workload-identity module with use_existing_gcp_sa and gcp_sa_name set #1002

msonnleitner opened this issue Sep 17, 2021 · 1 comment · Fixed by #1003

Comments

@msonnleitner
Copy link

When using the workload-identity module with variables gcp_sa_name and use_existing_gcp_sa set, it seems that instead of gcp_sa_name name is used. Should there not be used the computed value gcp_given_name as well?

terraform-google-kubernetes-engine/modules/workload-identity/main.tf

Line 35 in 29bdc55

account_id = var.name

morgante added a commit that referenced this issue Sep 17, 2021
@morgante
fix: Use provided gcp_given_name for workload identity
5ffa7e8 
Fixes #1002
@morgante morgante mentioned this issue Sep 17, 2021
Merged
@morgante
Copy link
Contributor

Good catch, #1003 should fix this.

morgante added a commit that referenced this issue Sep 17, 2021
@morgante
fix: Use provided gcp_given_name for workload identity (#1003)
d72e595 
Fixes #1002
@morgante morgante mentioned this issue Sep 27, 2021
Closed
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this issue Jul 15, 2024
@morgante
fix: Use provided gcp_given_name for workload identity (terraform-goo…
b8ba937 
…gle-modules#1003)

Fixes terraform-google-modules#1002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@morgante @msonnleitner