Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use provided gcp_given_name for workload identity #1003

Merged
merged 1 commit into from
Sep 17, 2021
Merged

fix: Use provided gcp_given_name for workload identity #1003

merged 1 commit into from
Sep 17, 2021

Conversation

morgante
Copy link
Contributor

Fixes #1002

@morgante morgante mentioned this pull request Sep 17, 2021
Closed
@comment-bot-dev
Copy link

Thanks for the PR! 🚀
✅ Lint checks have passed.

@morgante
Copy link
Contributor Author

Test failure is unrelated.

@morgante morgante merged commit d72e595 into master Sep 17, 2021
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@morgante
fix: Use provided gcp_given_name for workload identity (terraform-goo…
b8ba937 
…gle-modules#1003)

Fixes terraform-google-modules#1002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

workload-identity module with use_existing_gcp_sa and gcp_sa_name set
3 participants
@morgante @comment-bot-dev @bharathkkb