Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document that var.grant_registry_access supports artifact registry #1015

Closed
5 tasks
jmymy opened this issue Oct 6, 2021 · 3 comments
Closed
5 tasks

Document that var.grant_registry_access supports artifact registry #1015

jmymy opened this issue Oct 6, 2021 · 3 comments
Labels
docs P3 medium priority issues triaged Scoped and ready for work

Comments

@jmymy
Copy link
Contributor

jmymy commented Oct 6, 2021

Artifact Registry improves and extends upon the existing capabilities of Container Registry, such as customer-managed encryption keys, VPC-SC support, Pub/Sub notifications, and more, providing a foundation for major upgrades in security, scalability, and control. While Container Registry is still available and will continue to be supported as a Google Enterprise API, going forward new features will only be available in Artifact Registry, and Container Registry will only receive critical security fixes.

  • new API to enable - artifactregistry.googleapis.com
  • The registry must exist before applying IAM
  • roles/artifactregistry.reader is the IAM role needed.
  • need to decide on what to do on the default behavior of the var.grant_registry_access = true and no var.registry_project_ids provided, in the past, it would use the current project as the location to add iam
  • Support KMS and CMEK in the IAM permissions for the service_account for the custer?
@morgante
Copy link
Contributor

morgante commented Oct 6, 2021

This was already implemented in #719. Is it not working for you?

@jmymy
Copy link
Contributor Author

jmymy commented Oct 6, 2021

And there it is!

Looks like this isn't mentioned in the readme? Only mentions the old behavior

@bharathkkb
Copy link
Member

We should update the docs to reflect this

@bharathkkb bharathkkb changed the title var.grant_registry_access should support artifact registry Document that var.grant_registry_access supports artifact registry Oct 7, 2021
@bharathkkb bharathkkb added docs P3 medium priority issues triaged Scoped and ready for work labels Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs P3 medium priority issues triaged Scoped and ready for work
Projects
None yet
Development

No branches or pull requests

4 participants