Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for artifact registry #719

Closed
weeco opened this issue Oct 19, 2020 · 1 comment
Closed

Add support for artifact registry #719

weeco opened this issue Oct 19, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers P2 high priority issues triaged Scoped and ready for work

Comments

@weeco
Copy link

weeco commented Oct 19, 2020

Currently it's possible to set the registry_project_id which grants storage.objectViewer so that the GKE service account can pull images from the container registry in the respective project. See: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/modules/beta-private-cluster/variables.tf#L320-L324

If I want to use the artifact registry (which seems to be the successor of the container registry), I do need different IAM permissions - such as the Artifact Registry Reader permission.
@morgante morgante added enhancement New feature or request good first issue Good for newcomers P2 high priority issues triaged Scoped and ready for work labels Oct 19, 2020
davidholsgrove added a commit to davidholsgrove/terraform-google-kubernetes-engine that referenced this issue Nov 27, 2020
@davidholsgrove
terraform-google-modules#719 Add roles/artifactregistry.reader to ser…
a2302b9 
…viceaccount
@bharathkkb
Copy link
Member

fixed by #748

@morgante morgante mentioned this issue Oct 6, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers P2 high priority issues triaged Scoped and ready for work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@morgante @bharathkkb @weeco