fix: adds metadata to the default node pool #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-awmalik
requested review from
bharathkkb,
Jberlinsky and
a team
as code owners
|
Thanks for the PR! 🚀 |
|
@bharathkkb - can you please review this? |
bharathkkb
changed the title
|
@g-awmalik could you check the upgrade scenario from main to this patch if a user has already set |
|
hey @bharathkkb - I already checked that and its noop like you said. |
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…#1018) * fix:adds metadata to the default node pool * This removes the default_node_pool metadata map Co-authored-by: Awais Malik <awmalik@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #1000 where the default node pool doesn't accept the metadata provided as part of the module calling it. Now metadata included in "all" as well as "default-node-pool" will be applied to the default node pool preventing it from crashing in case of a specific policy constraint.