Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and test var.grant_registry_access supports artifact registry #1044

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

stanley98yu
Copy link
Contributor

Mainly documentation changes, but I added a small change to a test to see if the role is properly assigned. Let me know if I should add anything else.

Issue reference: #1015

@comment-bot-dev
Copy link

Thanks for the PR! 🚀
✅ Lint checks have passed.

@stanley98yu stanley98yu requested a review from a team November 2, 2021 22:15
@stanley98yu stanley98yu marked this pull request as ready for review November 2, 2021 22:15
@morgante morgante merged commit d3ca023 into master Nov 2, 2021
@morgante morgante deleted the fix/artifact-registry branch November 2, 2021 23:24
@sreenivas-ps
Copy link

@stanley98yu : does this enable_confidential_nodes work? I'm using this version "terraform-google-modules/kubernetes-engine/google//modules/beta-private-cluster" but getting this error:

Error: Unsupported argument

  on gke.tf line 70, in module "gke2":
  70:   enable_confidential_nodes = true

An argument named "enable_confidential_nodes" is not expected here.

@stanley98yu
Copy link
Contributor Author

Hello @sreenivas-ps, I believe the enable_confidential_nodes field should work--see simple_regional_private_beta for an example. My first thought based on what you posted is to try changing the module name to "gke". If the problem persists, please open an issue to get it debugged.

CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants