Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass REVISION_NAME to downstream ASM install script #1048

Merged

Conversation

jtangney
Copy link
Contributor

@jtangney jtangney commented Nov 3, 2021

Fixes #1022

@comment-bot-dev
Copy link

comment-bot-dev commented Nov 3, 2021

Thanks for the PR! 🚀
✅ Lint checks have passed.

@jtangney jtangney changed the title fix: pass REVISION_NAME to downstream install script fix: pass REVISION_NAME to downstream ASM install script Nov 3, 2021
@jtangney
Copy link
Contributor Author

jtangney commented Nov 3, 2021

This error seems unrelated to my changes - and is affecting other PRs

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have a PR out to fix the other unrelated error and will rerun trigger tests after thats merged

@bharathkkb bharathkkb merged commit dd410d7 into terraform-google-modules:master Nov 11, 2021
@jtangney jtangney deleted the fix/asm-revision-name branch November 11, 2021 09:26
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASM module: "revision_name" variable not passed through
3 participants