Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: update kube-dns configMap using kubernetes_config_map_v1_data #1214

Merged
merged 2 commits into from
Apr 14, 2022
Merged

feat!: update kube-dns configMap using kubernetes_config_map_v1_data #1214

merged 2 commits into from
Apr 14, 2022

Conversation

apeabody
Copy link
Contributor

@apeabody apeabody commented Apr 11, 2022 •
edited
Loading

@morgante
Copy link
Contributor

We'll probably want to use force = true to override any settings provided by addon-manager.

@apeabody
Copy link
Contributor Author

We'll probably want to use force = true to override any settings provided by addon-manager.

good point

@comment-bot-dev
Copy link

comment-bot-dev commented Apr 11, 2022 •
edited
Loading

Thanks for the PR! 🚀
✅ Lint checks have passed.

@bharathkkb
Copy link
Member

Marking as a breaking change due to new min k8s provider version. @apeabody It would be good add an upgrade guide as the gcloud module may show some diffs.

@bharathkkb bharathkkb changed the title feat: update kube-dns configMap using kubernetes_config_map_v1_data feat!: update kube-dns configMap using kubernetes_config_map_v1_data Apr 12, 2022
@apeabody apeabody marked this pull request as ready for review April 13, 2022 21:38
@apeabody apeabody requested review from a team and Jberlinsky as code owners April 13, 2022 21:38
bharathkkb
bharathkkb approved these changes Apr 13, 2022
View reviewed changes
docs/upgrading_to_v21.0.md Show resolved Hide resolved
docs/upgrading_to_v21.0.md Outdated Show resolved Hide resolved
docs/upgrading_to_v21.0.md Outdated Show resolved Hide resolved
@apeabody apeabody mentioned this pull request Apr 14, 2022
Closed
@bharathkkb bharathkkb merged commit 8547935 into terraform-google-modules:master Apr 14, 2022
@apeabody apeabody deleted the fix-patch-4 branch April 14, 2022 18:05
@release-please release-please bot mentioned this pull request Apr 14, 2022
Merged
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
@apeabody
feat!: update kube-dns configMap using kubernetes_config_map_v1_data (t…
6d5d1c3 
…erraform-google-modules#1214)

* feat!: kube-dns using kubernetes_config_map_v1_data

* fix: node_pool test with node auto-provisioning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@Jberlinsky Jberlinsky Awaiting requested review from Jberlinsky

Assignees
No one assigned
Labels
breaking
Projects
None yet
Milestone
No milestone
4 participants
@apeabody @morgante @comment-bot-dev @bharathkkb