Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing keeper in update variants for enable_gcfs node pool option #1217

Closed
lauraseidler opened this issue Apr 12, 2022 · 0 comments · Fixed by #1218 or #1185
Closed

Missing keeper in update variants for enable_gcfs node pool option #1217

lauraseidler opened this issue Apr 12, 2022 · 0 comments · Fixed by #1218 or #1185
Labels
bug Something isn't working

Comments

@lauraseidler
Copy link
Contributor

TL;DR

Adding the gcfs_config block (controlled through enable_gcfs option for node pools) forces the node pool to get re-created, but the keeper is missing for the update variants, causing the apply to fail.

Expected behavior

New node pool gets created, and then the old node pool gets destroyed.

Observed behavior

Upgrade fails, as node pool with the same name already exists.

Terraform Configuration

Any update-variant cluster with a node pool that was created before #1174 got merged

Terraform Version

$ terraform version      
Terraform v1.1.8
on linux_amd64
+ provider registry.terraform.io/hashicorp/external v2.2.2
+ provider registry.terraform.io/hashicorp/google v4.10.0
+ provider registry.terraform.io/hashicorp/google-beta v4.10.0
+ provider registry.terraform.io/hashicorp/kubernetes v2.9.0
+ provider registry.terraform.io/hashicorp/null v3.1.1
+ provider registry.terraform.io/hashicorp/random v3.1.2
+ provider registry.terraform.io/hashicorp/time v0.7.2

Additional information

I'll provide a PR for this shortly.

Note: Enabling/disabling image streaming via gcloud is possible without re-creating the node pool, but this doesn't seem to be supported by the current provider version.
@lauraseidler lauraseidler added the bug Something isn't working label Apr 12, 2022
lauraseidler added a commit to lauraseidler/terraform-google-kubernetes-engine that referenced this issue Apr 12, 2022
@lauraseidler
Add keeper for gcfs_enabled for update variants
66c39ff 
As changing the `gcfs_config` block currently forces a replacement of
the node pool, see:
https://github.com/hashicorp/terraform-provider-google/blob/5290a9f74d491bd3a05c32cdc60773ac6c53d4ae/google/node_config.go#L119

Fixes terraform-google-modules#1217
lauraseidler added a commit to lauraseidler/terraform-google-kubernetes-engine that referenced this issue Apr 12, 2022
@lauraseidler
Add keeper for gcfs_enabled node pool option for update variants
28269e8 
As changing the `gcfs_config` block currently forces a replacement of
the node pool, see:
https://github.com/hashicorp/terraform-provider-google/blob/5290a9f74d491bd3a05c32cdc60773ac6c53d4ae/google/node_config.go#L119

Fixes terraform-google-modules#1217
@lauraseidler lauraseidler mentioned this issue Apr 12, 2022
Merged
lauraseidler added a commit to lauraseidler/terraform-google-kubernetes-engine that referenced this issue Apr 12, 2022
@lauraseidler
Add keeper for enable_gcfs node pool option for update variants
7b049e6 
As changing the `gcfs_config` block currently forces a replacement of
the node pool, see:
https://github.com/hashicorp/terraform-provider-google/blob/5290a9f74d491bd3a05c32cdc60773ac6c53d4ae/google/node_config.go#L119

Fixes terraform-google-modules#1217
bharathkkb added a commit that referenced this issue Apr 15, 2022
@lauraseidler @bharathkkb
feat: Add keeper for enable_gcfs node pool option for update varian…
f431756 
…ts (#1218)

As changing the `gcfs_config` block currently forces a replacement of
the node pool, see:
https://github.com/hashicorp/terraform-provider-google/blob/5290a9f74d491bd3a05c32cdc60773ac6c53d4ae/google/node_config.go#L119

Fixes #1217

Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
@release-please release-please bot mentioned this issue Apr 15, 2022
Merged
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this issue Jul 15, 2024
@lauraseidler @bharathkkb
feat: Add keeper for enable_gcfs node pool option for update varian…
c532455 
…ts (terraform-google-modules#1218)

As changing the `gcfs_config` block currently forces a replacement of
the node pool, see:
https://github.com/hashicorp/terraform-provider-google/blob/5290a9f74d491bd3a05c32cdc60773ac6c53d4ae/google/node_config.go#L119

Fixes terraform-google-modules#1217

Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@lauraseidler