Add keeper for enable_gcfs node pool option for update variants
#1218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauraseidler
requested review from
a team,
Jberlinsky and
bharathkkb
as code owners
As changing the `gcfs_config` block currently forces a replacement of the node pool, see: https://github.com/hashicorp/terraform-provider-google/blob/5290a9f74d491bd3a05c32cdc60773ac6c53d4ae/google/node_config.go#L119 Fixes terraform-google-modules#1217
lauraseidler
force-pushed
the
fix/gcfs-keeper
branch
from
28269e8
to
7b049e6
Compare
lauraseidler
changed the title
gcfs_enabled node pool option for update variantsenable_gcfs node pool option for update variants
|
Thanks for the PR! 🚀 |
|
Thank you for fixing this. |
bharathkkb
approved these changes
Apr 15, 2022
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…ts (terraform-google-modules#1218) As changing the `gcfs_config` block currently forces a replacement of the node pool, see: https://github.com/hashicorp/terraform-provider-google/blob/5290a9f74d491bd3a05c32cdc60773ac6c53d4ae/google/node_config.go#L119 Fixes terraform-google-modules#1217 Co-authored-by: Bharath KKB <bharathkrishnakb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As changing the
gcfs_configblock currently forces a replacement ofthe node pool, see:
https://github.com/hashicorp/terraform-provider-google/blob/5290a9f74d491bd3a05c32cdc60773ac6c53d4ae/google/node_config.go#L119
Fixes #1217