Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurring maintenace window #1262

Merged

Conversation

X4mp
Copy link
Contributor

@X4mp X4mp commented May 20, 2022

This extends #397 to all clusters. Closes #1204

The code changes are based on #1242 and extended by documentation and generated input tables.

Roland Urbano added 2 commits May 20, 2022 10:54
Signed-off-by: Roland Urbano <roland.urbano@datenkraft.com>
Signed-off-by: Roland Urbano <roland.urbano@datenkraft.com>
@X4mp X4mp requested review from a team, Jberlinsky and bharathkkb as code owners May 20, 2022 09:26
@google-cla
Copy link

google-cla bot commented May 20, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@comment-bot-dev
Copy link

comment-bot-dev commented May 20, 2022

Thanks for the PR! 🚀
✅ Lint checks have passed.

@X4mp
Copy link
Contributor Author

X4mp commented May 20, 2022

Hey,
Unfortunately I can't see why the kubernetes-engine-int-trigger check failed.

Signed-off-by: Roland Urbano <roland.urbano@datenkraft.com>

Autogenerated documentation and variable inputs

Signed-off-by: Roland Urbano <roland.urbano@datenkraft.com>
@X4mp X4mp force-pushed the recurring-maintenace-window branch from 1521333 to f9b3f90 Compare May 24, 2022 16:15
@X4mp
Copy link
Contributor Author

X4mp commented May 27, 2022

Any chance someone can help me look into the kubernetes-engine-int-trigger and see why the check failed?

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @X4mp

@bharathkkb bharathkkb merged commit 4bba52f into terraform-google-modules:master May 31, 2022
bmenasha pushed a commit to bmenasha/terraform-google-kubernetes-engine that referenced this pull request Feb 17, 2023
* Added code changes from terraform-google-modules#1242

Signed-off-by: Roland Urbano <roland.urbano@datenkraft.com>

* Added variable definition for new inputs

Signed-off-by: Roland Urbano <roland.urbano@datenkraft.com>

* Extended READMEs for new inputs and added documentation

Signed-off-by: Roland Urbano <roland.urbano@datenkraft.com>

Autogenerated documentation and variable inputs

Signed-off-by: Roland Urbano <roland.urbano@datenkraft.com>

Co-authored-by: Roland Urbano <roland.urbano@datenkraft.com>
Co-authored-by: Andrew Peabody <andrewpeabody@google.com>
CPL-markus pushed a commit to WALTER-GROUP/terraform-google-kubernetes-engine that referenced this pull request Jul 15, 2024
* Added code changes from terraform-google-modules#1242

Signed-off-by: Roland Urbano <roland.urbano@datenkraft.com>

* Added variable definition for new inputs

Signed-off-by: Roland Urbano <roland.urbano@datenkraft.com>

* Extended READMEs for new inputs and added documentation

Signed-off-by: Roland Urbano <roland.urbano@datenkraft.com>

Autogenerated documentation and variable inputs

Signed-off-by: Roland Urbano <roland.urbano@datenkraft.com>

Co-authored-by: Roland Urbano <roland.urbano@datenkraft.com>
Co-authored-by: Andrew Peabody <andrewpeabody@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify maintenance policy
4 participants